adds simpler Nim's AST to/from NIF #25243
Draft
+2,762
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite #25201.
This PR traverse PNode and when it get an unknown type, encode it to
(typeId <type id> <fields of PType>)and add it to a set of encoded PType.When it get the same type again, encode it to
(t <type id>)and doesn't traverse fields of the type.PSym are also encoded in the similar way.
So it can encode PNode to NIF even if there are cycles in PType.
This PR is simpler than #25201 as it doesn't contains type or statement specific code.