Fixes #25202 #25244
Merged
Fixes #25202 #25244
+152
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yglukhov
force-pushed
the
fix-25202
branch
2 times, most recently
from
5cf6327 to
1853432
Compare
|
Not sure what's going on with chronos on macos. Unfortunately I don't have a mac right now to investigate. Would appreciate anyone looking into it. |
|
FWIW, it seems the chronos fail is unrelated to this PR, as now I've seen the same test failing with the same error in a different commit. |
|
@cheatfate has fixed chronos: status-im/nim-chronos#592, CI is now green. |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.