chore: replace elk references listed in "Content to update" section #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nimbus-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nimbus-town ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shuuji3
changed the title
shuuji3
changed the title
anbraten
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can check all checkboxes in "Content to update" in #6 with this PR.
There are two files not included in this PR but I think it's not necessary to replace them:
components/publish/PublishWidget.vue- It has a reference only in code comment to Elk repository so we don't need to replace it.modules/tauri/index.ts- There's a reference toelk-og.png(app's preview image). I think we don't need to update for now as tauri app is not maintained now. We will be able to update it if we resume tauri app for Nimbus.