Skip to content

Use full namespace for builder field #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use full namespace for builder field #32

wants to merge 1 commit into from

Conversation

ugexe
Copy link
Contributor

@ugexe ugexe commented Jun 21, 2018

No description provided.

@ugexe
Copy link
Contributor Author

ugexe commented Jun 21, 2018

zef has special-cased 'MakeFromJSON' for the time being. Some time in the near future you should be able to merge this with little fallout.

@ugexe
Copy link
Contributor Author

ugexe commented Aug 6, 2018

@niner how shall we handle this in install-dist.pl? Do we do my $builder-class = first { *.so }, (try require ::("$name")), (try require ::("Distribution::Builder::$name") with a deprecation warning, or should we just cut straight to ::("$name")?

@ugexe
Copy link
Contributor Author

ugexe commented Aug 11, 2018

install-dist.p6 will handle a full namespace or the original implied prefix version as of rakudo/rakudo@0249afc and the spec updated as of Raku/old-design-docs@26266b1 to reflect that using the full namespace is the new correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant