Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a more thorough clean method #767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

niosus
Copy link
Owner

@niosus niosus commented Jan 23, 2022

Before we would only clean cmake cache and that operation would regularly fail due to a bug in the code. This PR allows to clear all internal cache including the temporary folders generated before.

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #767 (58faf01) into master (3b16eb1) will decrease coverage by 0.85%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
- Coverage   82.16%   81.31%   -0.86%     
==========================================
  Files          39       39              
  Lines        3319     3328       +9     
==========================================
- Hits         2727     2706      -21     
- Misses        592      622      +30     
Impacted Files Coverage Δ
plugin/utils/tools.py 89.47% <0.00%> (ø)
plugin/view_config/view_config_manager.py 70.58% <16.66%> (-3.38%) ⬇️
plugin/flags_sources/cmake_file.py 80.89% <50.00%> (-0.93%) ⬇️
plugin/flags_sources/bazel.py 39.28% <0.00%> (-46.43%) ⬇️
plugin/utils/clang_utils.py 73.50% <0.00%> (-4.64%) ⬇️
plugin/utils/catkinizer.py 54.21% <0.00%> (-3.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e8913...58faf01. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant