Skip to content

Conversation

@arokem
Copy link
Collaborator

@arokem arokem commented Apr 13, 2020

Continues the work started in #78

@pull-assistant
Copy link

pull-assistant bot commented Apr 13, 2020

@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

❌ Patch coverage is 31.74603% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.40%. Comparing base (6b95611) to head (fed7e78).
⚠️ Report is 293 commits behind head on master.

Files with missing lines Patch % Lines
dmriprep/utils/register.py 31.74% 43 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   50.34%   49.40%   -0.95%     
==========================================
  Files          21       22       +1     
  Lines        1289     1352      +63     
  Branches      169      174       +5     
==========================================
+ Hits          649      668      +19     
- Misses        628      672      +44     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pep8speaks
Copy link

pep8speaks commented Apr 13, 2020

Hello @arokem, Thank you for updating!

Line 79:5: F841 local variable 'transformed' is assigned to but never used
Line 134:1: F811 redefinition of unused 'AffineRegistration' from line 10
Line 137:9: F841 local variable 'nbins' is assigned to but never used
Line 138:9: F841 local variable 'sampling_prop' is assigned to but never used
Line 139:9: F841 local variable 'metric' is assigned to but never used
Line 140:9: F841 local variable 'level_iters' is assigned to but never used
Line 141:9: F841 local variable 'sigmas' is assigned to but never used
Line 142:9: F841 local variable 'factors' is assigned to but never used
Line 143:9: F841 local variable 'pipeline' is assigned to but never used

To test for issues locally, pip install flake8 and then run flake8 dmriprep.

Comment last updated at 2020-09-29 15:30:40 UTC

@arokem arokem force-pushed the registration_tools_arokem branch from 18f92d9 to 04a843e Compare August 17, 2020 15:55
@oesteban
Copy link
Member

My plan is to rebase this on top of #78 after Derek updates that branch.

@oesteban oesteban mentioned this pull request Oct 17, 2025
@oesteban
Copy link
Member

see #78 (comment)

@oesteban oesteban closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants