Skip to content

Conversation

mathesong
Copy link

I've had a first attempt at changing all the TAC output in _timeseries.tsv files to _tacs.tsv files. I've left the desc-confounds_timeseries.tsv files as _timeseries.tsv though.

I've also added _tacs.tsv to the .bidsignore files.

If I've missed anyplace else that I should make these changes, do please let me know.

@mathesong mathesong marked this pull request as draft August 19, 2025 12:00
@mathesong mathesong marked this pull request as ready for review August 19, 2025 12:00
@effigies effigies changed the title FIX:Change TAC outputs from _timeseries.tsv to _tacs.tsv FIX: Change TAC outputs from _timeseries.tsv to _tacs.tsv Aug 19, 2025
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.33%. Comparing base (7bd4dfd) to head (2636310).

Files with missing lines Patch % Lines
petprep/interfaces/tests/test_tacs.py 0.00% 1 Missing ⚠️
petprep/workflows/pet/tacs.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (7bd4dfd) and HEAD (2636310). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (7bd4dfd) HEAD (2636310)
9 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #82       +/-   ##
==========================================
- Coverage   77.77%   0.33%   -77.44%     
==========================================
  Files          80      80               
  Lines        5952    5952               
  Branches      614     613        -1     
==========================================
- Hits         4629      20     -4609     
- Misses       1167    5932     +4765     
+ Partials      156       0      -156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@mnoergaard mnoergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me - thanks @mathesong. We should also change the column names of the timing information so they are in line with petprep_extract_tacs. Finally, we also need to adjust the nipreps.json files in niworkflows and within petprep to allow the _tacs suffix for reading and writing the files.

https://github.com/nipreps/niworkflows/blob/master/niworkflows/data/nipreps.json
https://github.com/nipreps/petprep/blob/main/petprep/data/nipreps.json

@mnoergaard
Copy link
Collaborator

Closed as completed via #114

@mnoergaard mnoergaard closed this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants