STYLE: Fix type checking errors in volumeutils.rec2dict
#1424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
+ Coverage 95.34% 95.43% +0.09%
==========================================
Files 209 209
Lines 29780 29784 +4
Branches 3357 4472 +1115
==========================================
+ Hits 28393 28425 +32
+ Misses 948 926 -22
+ Partials 439 433 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhlegarreta
force-pushed
the
FixTypecheckErrors
branch
from
fa614ce to
0e7f41c
Compare
Fix type checking errors in `volumeutils.rec2dict`: - Ensure that the recarray is iterable; return immediately if no fields are found. - Accomodate `Any` type in return the dictionary type Fixes: ``` nibabel/volumeutils.py:1391: error: Item "None" of "MappingProxyType[str, tuple[dtype[Any], int] | tuple[dtype[Any], int, Any]] | None" has no attribute "__iter__" (not iterable) [union-attr] ``` and ``` nibabel/volumeutils.py:1398: error: Incompatible return value type (got "dict[str | Any, ndarray[tuple[Any, ...], dtype[Any]]]", expected "dict[str, generic[Any] | ndarray[tuple[Any, ...], dtype[Any]]]") [return-value] nibabel/volumeutils.py:1398: note: Perhaps you need a type annotation for "dct"? Suggestion: "dict[str, generic[Any] | ndarray[tuple[Any, ...], dtype[Any]]]" ``` raised for example in: https://github.com/nipy/nibabel/actions/runs/16092302666/job/45410655458?pr=1422#step:7:22
jhlegarreta
force-pushed
the
FixTypecheckErrors
branch
from
0e7f41c to
1ed2b6c
Compare
|
@effigies This is ready to be merged. |
This was referenced Jul 5, 2025
effigies
reviewed
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix type checking errors in
volumeutils.rec2dict:Anytype in return the dictionary typeFixes:
and
raised for example in:
https://github.com/nipy/nibabel/actions/runs/16092302666/job/45410655458?pr=1422#step:7:22