sty: Apply ruff fix for looped file.write #1433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
file.writelines() does not add newlines. I have also checked the source code and it iterates over whatever is passed, so there should be no impact on memory usage.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1433 +/- ##
=======================================
Coverage 95.43% 95.44%
=======================================
Files 209 209
Lines 29784 29782 -2
Branches 4472 4472
=======================================
- Hits 28425 28424 -1
+ Misses 926 925 -1
Partials 433 433 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file.writelines()does not add newlines. I have also checked the cpython source code, and it iterates over whatever is passed, so there should be no impact on memory usage.Supersedes #1423.