Open
Conversation
PradeepITT
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why this code violating DIP?
public class EmployeeService {
private Database database = new Database();
}
public class Database {
public void save(Employee employee) {
// Code to save employee to the database
}
}
public class Employee {
private String name;
private String address;
}
Note: This code is violating DIP because "EmployeeService" class is directly dependent on a concrete implementation of the Database class.
This approach violates the Dependency Inversion Principle (DIP) because any change in the database implementation would require modifications to the EmployeeService class. According to DIP, high-level modules such as EmployeeService should depend on abstractions (interfaces) rather than on concrete implementations.