Remake/administration #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryansri-19
force-pushed
the
remake/administration
branch
from
441263c to
eb2c8cc
Compare
aryansri-19
force-pushed
the
remake/administration
branch
from
eb2c8cc to
c096dce
Compare
|
Sab galat |
what galat |
aryansri-19
force-pushed
the
remake/administration
branch
from
c096dce to
fac4281
Compare
aryansri-19
force-pushed
the
remake/administration
branch
from
fac4281 to
ac6ef7f
Compare
|
|
aryansri-19
force-pushed
the
remake/administration
branch
from
423eeaf to
cacb1af
Compare
heydoyouknowme0
force-pushed
the
remake/administration
branch
from
cacb1af to
1ef21ce
Compare
geekysilento
previously approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
app/[locale]/institute/administration/page.tsx:145
- [nitpick] The class 'size-12' is ambiguous; consider using a more descriptive name that aligns with your design system or confirm that it is defined in your CSS.
<Icon className="size-12" />
|
@aryansri-19 rebase |
aryansri-19
force-pushed
the
remake/administration
branch
from
f82f422 to
815e2d3
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
app/[locale]/institute/administration/page.tsx:237
- The pointsOfApprovalLinks array length does not match the number of items resulting from text.pointsOfApproval.slice(4), which could lead to undefined links. Consider ensuring both arrays are aligned or add a fallback to handle the absence of a corresponding link.
pointsOfApprovalLinks[index + 4] ? (
| return <WorkInProgressStatus locale={locale} />; | ||
| const text = (await getTranslations(locale)).Administration; | ||
|
|
||
| const senateMembers = await db.query.committeeMembers.findMany({ |
There was a problem hiding this comment.
so just empty table or no table if there is no member fetched?
| ]} | ||
| /> | ||
|
|
||
| <main className="container mt-20"> |
aryansri-19
force-pushed
the
remake/administration
branch
from
7d58b3c to
3fdefa8
Compare
aryansri-19
force-pushed
the
remake/administration
branch
from
3fdefa8 to
7ecdf0b
Compare
aryansri-19
force-pushed
the
remake/administration
branch
from
7ecdf0b to
8330446
Compare
aryansri-19
force-pushed
the
remake/administration
branch
from
8330446 to
af2cada
Compare
aryansri-19
force-pushed
the
remake/administration
branch
from
af2cada to
7a2a64f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Administration Landing Static page
Missing staff data as db is not populated.