Security Page #258
Security Page #258
Conversation
|
You didnt change anything from suyash's PR, were you not informed? |
| <Card className="bg-white mx-4 border-[#971F16] bg-neutral-50 py-4 font-sans font-medium tracking-wide sm:mx-6 md:mx-10 lg:mx-24"> | ||
| <CardContent> | ||
| <CardDescription className="text-black mb-4 line-clamp-6"> | ||
| {text.card2.content1} |
There was a problem hiding this comment.
use a .map() instead of doing this repeatedly
| ></ImageHeader> | ||
|
|
||
| <section className="mt-10 px-4 sm:px-6 md:px-10 lg:px-24"> | ||
| <Card className=" my-0 border-none py-4 font-sans text-xs font-semibold tracking-wide shadow-none sm:text-xl md:text-2xl lg:text-[40px]"> |
There was a problem hiding this comment.
Don't use <Card>, see how these type of components are made in other pages, like /institute/sections/library/page.tsx
| <CardDescription className="text-black leading-[20px] font-sans text-justify mb-4"> | ||
| {text.article.description3} | ||
| </CardDescription> | ||
| <CardDescription className="text-black leading-[20px] font-sans text-justify mb-4"> |
There was a problem hiding this comment.
| <CardDescription className="text-black leading-[20px] font-sans text-justify mb-4"> | |
| <CardDescription className="leading-[20px] font-sans text-justify mb-4"> |
dont use text colors that aren't already custom defined in our color palette in the tailwind.config.ts file
| </Card> | ||
| </section> | ||
|
|
||
| <section className="mt-12 "> |
There was a problem hiding this comment.
| <section className="mt-12 "> | |
| <section className="mt-12"> |
you probably arent formatting ur code properly, ensure Prettier is configured and running.
| /> | ||
| </article> | ||
|
|
||
| <Card className="mx-4 my-0 border-[#971F16] bg-neutral-50 py-4 tracking-wide sm:mx-6 md:mx-10 lg:mx-24"> |
There was a problem hiding this comment.
| <Card className="mx-4 my-0 border-[#971F16] bg-neutral-50 py-4 tracking-wide sm:mx-6 md:mx-10 lg:mx-24"> | |
| <Card className="mx-4 my-0 border-primary-500 bg-neutral-50 py-4 tracking-wide sm:mx-6 md:mx-10 lg:mx-24"> |
again, dont use hardcoded values, use our color palette
components/image-header.tsx
Outdated
There was a problem hiding this comment.
this file shouldnt be part of ur PR, why is my commit a part of it, remove the entire commit from ur PR
i18n/en.ts
Outdated
| Security: { | ||
| title: 'SECURITY SECTION', | ||
| article: { | ||
| description1: |
There was a problem hiding this comment.
this should be an array instead of doing description 1,2,3 etc
i18n/translations.ts
Outdated
| description1: string; | ||
| description2: string; | ||
| description3: string; | ||
| description4: string; |
There was a problem hiding this comment.
| description1: string; | |
| description2: string; | |
| description3: string; | |
| description4: string; | |
| description: string[]; |
this should be an array and shown using the .map function as mentioned earlier
kartik-vats
force-pushed
the
feature/security
branch
from
ab2a55a to
42df00c
Compare
heydoyouknowme0
changed the base branch from
feature/security-section
to
master
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
app/[locale]/institute/sections/security/page.tsx:14
- The translations are defined with 'Security' at the root level in the translation files, but the code accesses 'Section.Security'. Consider updating the property access to match the translations structure.
const text = (await getTranslations(locale)).Section.Security;
No description provided.