Skip to content

Feat/clubs (Draft PR | Working on it) #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Debatreya
Copy link
Member

No description provided.

@Debatreya Debatreya marked this pull request as ready for review March 15, 2025 07:13
@Debatreya
Copy link
Member Author

@geekysilento can you look into this once

@heydoyouknowme0 heydoyouknowme0 requested review from Copilot and geekysilento and removed request for Copilot April 10, 2025 13:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

server/db/schema/notifications.schema.ts:26

  • It appears that the 'clubId' reference is commented out. If this feature is intended, please uncomment it or remove the comment to avoid confusion.
    // clubId: integer('club_id').references(() => clubs.id),

id: number;
title: string;
date: string;
image: [string];
Copy link
Preview

Copilot AI Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type declaration 'image: [string];' may unintentionally define a fixed-length tuple instead of an array. Consider using 'string[]' to properly represent an array of strings.

Suggested change
image: [string];
image: string[];

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

@geekysilento
Copy link
Member

Please don't fork the repository, create a new branch on this repo itself to ensure vercel can deploy your branch. @Debatreya

@Debatreya
Copy link
Member Author

Please don't fork the repository, create a new branch on this repo itself to ensure vercel can deploy your branch. @Debatreya

I am not a member or something or I don't have write access. I don't have permission to directly push anything in this repo

@Aryawart-kathpal
Copy link

@geekysilento add me and @Debatreya as contributors to this repo.

@geekysilento
Copy link
Member

added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants