fix(tailwind): resolve custom classNames recognition #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heydoyouknowme0
requested review from
Copilot and
GetPsyched
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR updates the custom Tailwind class name props in various UI components to use a nested object property called classNames instead of individual props.
- Replaces multiple props (e.g., scrollAreaClassName, inputClassName, badgeClassName) with a unified classNames object.
- Updates component implementations in table, scroll-area, inputs, carousels, buttons, search, login, and library pages to support the new API.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| components/ui/table.tsx | Updated component prop interface to use classNames and applied the new keys in the ScrollArea usage. |
| components/ui/scroll-area.tsx | Changed prop interface to use classNames for scrollBar styling and updated its usage. |
| components/inputs/multi-select.tsx | Replaced badgeClassName with classNames for badge styling. |
| components/inputs/input.tsx | Converted inputClassName into classNames for input styling. |
| components/carousels/gallery.tsx | Updated itemClassName prop to classNames for item styling. |
| components/buttons/bouncy-arrow.tsx | Modified arrowClassName to classNames for arrow styling. |
| app/[locale]/search/search.tsx | Adapted Input and BouncyArrowButton usage to the new classNames API. |
| app/[locale]/login/login.tsx | Changed Input component usage from inputClassName to classNames. |
| app/[locale]/institute/sections/library/collection-and-resources/page.tsx | Updated Table usage but passed classNames with the wrong key. |
app/[locale]/institute/sections/library/collection-and-resources/page.tsx
Outdated
Show resolved
Hide resolved
heydoyouknowme0
force-pushed
the
fix/taiwind-classes
branch
from
4ea94b4 to
d39224b
Compare
GetPsyched
reviewed
Mar 29, 2025
heydoyouknowme0
force-pushed
the
fix/taiwind-classes
branch
from
d39224b to
f35af59
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates various UI components to use a consolidated "classNames" prop instead of multiple discrete class name props, specifically for improved Tailwind custom class recognition.
- Updated Table, ScrollArea, Input, MultiSelect, GalleryCarousel, and BouncyArrowButton components to accept a "classNames" object with related sub-keys.
- Modified app pages (search, login, library) to use the new "classNames" prop structure.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| components/ui/table.tsx | Replaced scrollAreaClassName with classNames.scrollArea and added classNames.scrollBar for the ScrollBar. |
| components/ui/scroll-area.tsx | Replaced scrollBarClassName with classNames.scrollBar. |
| components/inputs/multi-select.tsx | Replaced badgeClassName with classNames.badge. |
| components/inputs/input.tsx | Replaced inputClassName with classNames.input in component props and rendering. |
| components/carousels/gallery.tsx | Replaced itemClassName with classNames.item in the GalleryCarousel component. |
| components/buttons/bouncy-arrow.tsx | Replaced arrowClassName with classNames.arrow. |
| app/[locale]/search/search.tsx | Updated Input and BouncyArrowButton props to use the new classNames structure. |
| app/[locale]/login/login.tsx | Updated Input props to use classNames.input. |
| app/[locale]/institute/sections/library/collection-and-resources/page.tsx | Updated Table props to use classNames.scrollArea. |
|
I think this is good to merge right? |
heydoyouknowme0
force-pushed
the
fix/taiwind-classes
branch
from
f35af59 to
dee6100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.