fix: site title spelling and precedence #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses the site title spelling issues and adjusts the precedence of title translations for improved clarity across locales.
- Updated the Translations interface to include a "title" field with "big" and "small" keys.
- Added locale-specific translations in both hi.ts and en.ts.
- Updated the home page to reference the new translation keys.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| i18n/translations.ts | Added a new "title" property with "big" and "small" keys |
| i18n/hi.ts | Introduced Hindi and Latin title translations with updated spelling |
| i18n/en.ts | Introduced English title translations with updated precedence |
| app/[locale]/page.tsx | Modified the home page to display titles using the new translation keys |
Comments suppressed due to low confidence (1)
i18n/translations.ts:14
- [nitpick] The property names 'big' and 'small' might be ambiguous regarding their intended usage. Consider renaming them to 'primaryTitle' and 'secondaryTitle' to enhance clarity.
title: {
heydoyouknowme0
force-pushed
the
fix/title
branch
from
5f6966e to
c1b2779
Compare
geekysilento
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.