TEMPFIX: Hardcoded VS data #281

Debatreya · 2025-04-10T20:21:42Z

This pull request includes significant updates to the FacultySection component in page.tsx. The primary change is the addition of a new faculty profile for Vikram Singh, along with modifications to the logic that selects which profile to display based on the employee_id parameter.

Additions to Faculty Profile:

Added a detailed profile for Vikram Singh, including qualifications, publications, experience, projects, current education, scholars, and awards. (app/[locale]/faculty-and-staff/[employee_id]/[faculty_section]/page.tsxR115-R264)

Logic Updates:

Modified the profile selection logic to include Vikram Singh's profile when the employee_id is '1083'. (app/[locale]/faculty-and-staff/[employee_id]/[faculty_section]/page.tsxL217-R377)

Code Comments:

Added a TODO comment to address an issue where the frontend breaks if any section of the profile is empty. (app/[locale]/faculty-and-staff/[employee_id]/[faculty_section]/page.tsxL217-R377)

commit 8aa2014 Author: heydoyouknowme0 <[email protected]> Date: Sat Sep 28 11:58:39 2024 +0530 temp: dynamic hostels commit b92a240 Author: antkr <[email protected]> Date: Sun Jun 30 10:58:58 2024 +0530 feat:init hostels page

commit 92edbb9 Author: KambojRajan <[email protected]> Date: Fri Sep 13 20:17:14 2024 +0530 fix: remove console issues commit 4cd5a67 Author: KambojRajan <[email protected]> Date: Tue Aug 27 17:55:06 2024 +0530 fix: null icon issue commit bc82c96 Author: KambojRajan <[email protected]> Date: Thu Jul 4 18:45:44 2024 +0530 feat: sections-landing

Co-authored-by: KambojRajan <[email protected]>

commit 12f2dfe9e2e0163e16f27ec38d00efe0e086d418 Author: som-04 <[email protected]> Date: Mon May 13 10:46:45 2024 +0530 added: health centre page

commit 3d75069ae460fe9c1f6579da8836d61c7b2d18ff Author: KambojRajan <[email protected]> Date: Sat Sep 28 08:49:17 2024 +0530 init:academics landing

commit 03f2d23027d092c22a86be085df30e4aa6fcc64c Author: KambojRajan <[email protected]> Date: Wed Oct 2 07:55:21 2024 +0530 init: deans-landing

commit 39f108a Author: antri <[email protected]> Date: Sun May 26 20:06:47 2024 +0530 feat:central workshop page

…n translations

Copilot

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

app/[locale]/faculty-and-staff/[employee_id]/[faculty_section]/page.tsx

…/page.tsx Co-authored-by: Copilot <[email protected]>

Copilot

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Copilot · 2025-04-10T20:23:06Z

app/[locale]/faculty-and-staff/[employee_id]/[faculty_section]/page.tsx


  if (!profileTabs[faculty_section]) {
    return notFound();
  }

+  // TODO: (fix): If any section of profile is empty, the frontend is breaking


Consider implementing defensive checks or fallback values for empty profile sections to prevent the frontend from breaking rather than relying on the TODO comment as a reminder.

Suggested change

// TODO: (fix): If any section of profile is empty, the frontend is breaking

if (profileTabs[faculty_section].length === 0) {

return (

<div className="text-center text-neutral-500">

No data available for this section.

</div>

);

}

Copilot

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

app/[locale]/faculty-and-staff/[employee_id]/[faculty_section]/page.tsx:116

[nitpick] Consider using consistent naming conventions for profile objects. For example, if the existing profile 'jkchabbraProfile' uses camelCase with a capitalized name segment, consider renaming 'vikramsinghProfile' to 'vikramSinghProfile' or another consistent variant.

const vikramsinghProfile = {

Copilot

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

app/[locale]/faculty-and-staff/[employee_id]/[faculty_section]/page.tsx:116

[nitpick] Consider renaming 'vikramsinghProfile' to 'vikramSinghProfile' for consistency and improved readability.

const vikramsinghProfile = {

heydoyouknowme0 and others added 30 commits April 11, 2025 00:18

Squashed commit of the following:

eb3d7dd

commit 8aa2014 Author: heydoyouknowme0 <[email protected]> Date: Sat Sep 28 11:58:39 2024 +0530 temp: dynamic hostels commit b92a240 Author: antkr <[email protected]> Date: Sun Jun 30 10:58:58 2024 +0530 feat:init hostels page

feat: institute landing page

54d164a

feat: individual dean's page

db5d4f4

feat: curriculum page

953cb4d

fix: translation schema and coordinator typo

6969a8f

fix: updated curriculum page ui

03b2c86

feat: added accounts page

d3cc4e7

section/estate

b0e2294

feat: programmes page

ca6c1a8

Co-authored-by: KambojRajan <[email protected]>

feat: scholarships page

43c7139

Co-authored-by: KambojRajan <[email protected]>

faculty profile page

c7e0e54

feat: administration-landing init

dd89cd8

feat: convocation page init

de1da0d

feat: awards init

a45f047

feature: replaced footer loremipsum with dummy links

592d691

Squashed commit of the following:

a8c6850

commit 12f2dfe9e2e0163e16f27ec38d00efe0e086d418 Author: som-04 <[email protected]> Date: Mon May 13 10:46:45 2024 +0530 added: health centre page

Squashed commit of the following:

76955a3

commit 3d75069ae460fe9c1f6579da8836d61c7b2d18ff Author: KambojRajan <[email protected]> Date: Sat Sep 28 08:49:17 2024 +0530 init:academics landing

Squashed commit of the following:

dcd10aa

commit 03f2d23027d092c22a86be085df30e4aa6fcc64c Author: KambojRajan <[email protected]> Date: Wed Oct 2 07:55:21 2024 +0530 init: deans-landing

Squashed commit of the following:

7f31064

commit 39f108a Author: antri <[email protected]> Date: Sun May 26 20:06:47 2024 +0530 feat:central workshop page

feature/tnp

af313ba

campus infra

70a6103

chabbra details

0b16bf9

Added Administration Static Page

fcc7e8d

feat:navbar changes

352d102

hotfix: skill issue

7d3c2b1

added loading

a5e1e01

temp

94646cf

fixxx

2072e21

temp: force http typesense

34155be

geekysilento and others added 7 commits April 11, 2025 00:18

TEMPFIX: faculty profile picture fallback

a2bc1cb

TEMPFIX: administration description fix

a517384

fix: update footer links, slideshow icons and update copyright year i…

530014f

…n translations

feature: HOD message in department

8d56820

feature: add quick links section to homepage

18da860

refactor: move hostels page inside institute

29baadf

TEMPFIX: Hardcoded VS data

ab057a4

Debatreya requested review from Copilot and geekysilento April 10, 2025 20:21

Copilot AI reviewed Apr 10, 2025

View reviewed changes

app/[locale]/faculty-and-staff/[employee_id]/[faculty_section]/page.tsx Outdated Show resolved Hide resolved

Update app/[locale]/faculty-and-staff/[employee_id]/[faculty_section]…

f016051

…/page.tsx Co-authored-by: Copilot <[email protected]>

Debatreya requested a review from Copilot April 10, 2025 20:22

Copilot AI reviewed Apr 10, 2025

View reviewed changes

vercel bot deployed to Preview April 10, 2025 20:25 View deployment

Debatreya added 3 commits April 11, 2025 02:26

TEMPFIX: Data corrected for VS

6c6a449

FIXED THE NO DATA BREAKING THING

3920e5e

Merge conflict Resolve

b04f8fb

Debatreya requested a review from Copilot April 10, 2025 21:05

Copilot AI reviewed Apr 10, 2025

View reviewed changes

Debatreya requested a review from Copilot April 10, 2025 21:05

vercel bot deployed to Preview April 10, 2025 21:06 View deployment

Copilot AI reviewed Apr 10, 2025

View reviewed changes

heydoyouknowme0 force-pushed the staged branch 3 times, most recently from ecd9ba2 to 1a34505 Compare April 11, 2025 10:49

geekysilento force-pushed the staged branch from 1a34505 to d2929a3 Compare April 11, 2025 10:53

heydoyouknowme0 force-pushed the staged branch from d2929a3 to b6e1c44 Compare April 11, 2025 18:24

aryansri-19 force-pushed the staged branch from b6e1c44 to 767667b Compare June 9, 2025 07:26

aryansri-19 force-pushed the staged branch 2 times, most recently from 5d5f958 to a2249a1 Compare June 24, 2025 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

TEMPFIX: Hardcoded VS data #281

TEMPFIX: Hardcoded VS data #281

Uh oh!

Debatreya commented Apr 10, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 10, 2025

Uh oh!

geekysilento Apr 10, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

-  // TODO: (fix): If any section of profile is empty, the frontend is breaking
+  if (profileTabs[faculty_section].length === 0) {
+    return (
+      <div className="text-center text-neutral-500">
+        No data available for this section.
+      </div>
+    );
+  }

TEMPFIX: Hardcoded VS data #281

Are you sure you want to change the base?

TEMPFIX: Hardcoded VS data #281

Uh oh!

Conversation

Debatreya commented Apr 10, 2025

Additions to Faculty Profile:

Logic Updates:

Code Comments:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

geekysilento Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!