Feat/clubs #284

Aryawart-kathpal · 2025-04-11T09:26:25Z

Updted ui for single clubs page

Copilot

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (4)

server/db/schema/notifications.schema.ts:26

The commented-out clubId field suggests a missing foreign key relation in notifications; if not needed, consider removing it to avoid confusion.

// clubId: integer('club_id').references(() => clubs.id),

server/db/schema/clubs.schema.ts:43

Consider removing or updating the commented-out code for facultyInchargeId3 if it is no longer intended for use to improve code clarity.

// facultyInchargeId3: integer('faculty_incharge_id3').references(() => faculty.id

server/db/schema/events.ts:16

[nitpick] Consider using a more descriptive column name (e.g. 'start_date') instead of 'date' for the startDate field to improve clarity and consistency.

startDate: timestamp('date').notNull(),

app/[locale]/@modals/(.)student-activities/clubs/[dispaly_name]/event/page.tsx:1

The folder parameter '[dispaly_name]' appears to be misspelled; consider renaming it to '[display_name]' for consistency with other parts of the codebase.

import Image from 'next/image';

geekysilento · 2025-04-14T09:48:07Z

app/[locale]/academics/page.tsx

why modify this file

geekysilento · 2025-04-14T09:48:47Z

components/carousels/gallery.tsx

don't edit components unless you have a good reason to.

server/db/schema/clubs.schema.ts

aryansri-19 · 2025-04-14T10:42:02Z

Why are the changes commented out?
Also, don't make additional schema file for club Events, use the existing events.schema.ts and add necessary fields related to clubs such as clubId (nullable) etc. The category for all club events would be student so it fits with our current events schema.

Aryawart-kathpal · 2025-04-16T07:12:11Z

@aryansri-19 please review these schema changes
Deployement will fail for now, migration has to be created

aryansri-19

modify the faculty schema too for the many relation to clubHeads

server/db/schema/clubs.schema.ts

server/db/schema/notifications.schema.ts

server/db/schema/clubs.schema.ts

aryansri-19 · 2025-04-18T08:06:12Z

and rebase once.

app/[locale]/@modals/(.)student-activities/clubs/[display_name]/event/page.tsx

server/db/schema/club-heads.schema.ts

heydoyouknowme0 · 2025-04-20T17:51:21Z

components/image-header.tsx

@@ -42,9 +44,10 @@ export default function ImageHeader({
            {title}
          </h1>
        )}
+        {children}


out of scope of the pr

These changes were not made by me but priyanshu sir, I just reverted to this state.

What?, when?

{children} is required for the text(heading and logo) that is displayed on the top of banner.

hmm ok, just make that a separate commit when you are cleaning the tree, also why not just have a prop as image url or something similar, I think this is the only way we need something like this

In my latest commit, I have made this change, review this too..
I have added the display_name and logoUrl as props and removed the {chilren} prop.

Par yaar goal nahi mara

Aryawart-kathpal · 2025-04-21T06:55:37Z

@aryansri-19 please review the schema changes

heydoyouknowme0 · 2025-04-30T12:30:02Z

base your pr on master or another pr if its a stacked pr

This reverts commit d509924.

aryansri-19

😢

aryansri-19 · 2025-07-05T16:07:05Z

server/db/schema/notifications.schema.ts

      })
      .notNull(),
    createdAt: t.timestamp().defaultNow().notNull(),
    updatedAt: t
      .timestamp()
      .$onUpdate(() => new Date())
      .notNull(),
+    clubId: integer('club_id').references(() => clubs.id),


t.integer() callback method should be used.

aryansri-19 · 2025-07-05T16:09:46Z

app/[locale]/student-activities/clubs/[display_name]/event/page.tsx

Should be changed semantically. Although its modal is the one that will always open, yet it should at least render the correct page.

vercel bot deployed to Preview April 11, 2025 09:28 View deployment

heydoyouknowme0 requested a review from Copilot April 11, 2025 09:45

Copilot AI reviewed Apr 11, 2025

View reviewed changes

vercel bot deployed to Preview April 11, 2025 09:51 View deployment

geekysilento changed the base branch from master to staged April 11, 2025 10:00

heydoyouknowme0 force-pushed the staged branch 2 times, most recently from 74fbbae to ecd9ba2 Compare April 11, 2025 10:41

vercel bot deployed to Preview April 11, 2025 10:45 View deployment

heydoyouknowme0 force-pushed the staged branch from ecd9ba2 to 1a34505 Compare April 11, 2025 10:49

geekysilento force-pushed the staged branch from 1a34505 to d2929a3 Compare April 11, 2025 10:53

heydoyouknowme0 force-pushed the staged branch from d2929a3 to b6e1c44 Compare April 11, 2025 18:24

geekysilento reviewed Apr 14, 2025

View reviewed changes

app/[locale]/academics/page.tsx Outdated

Copy link

Member

geekysilento Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why modify this file

geekysilento reviewed Apr 14, 2025

View reviewed changes

components/carousels/gallery.tsx Outdated

Copy link

Member

geekysilento Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't edit components unless you have a good reason to.

geekysilento reviewed Apr 14, 2025

View reviewed changes

server/db/schema/clubs.schema.ts Show resolved Hide resolved

vercel bot deployed to Preview April 14, 2025 11:33 View deployment

vercel bot had a problem deploying to Preview April 16, 2025 07:10 Failure

aryansri-19 requested changes Apr 18, 2025

View reviewed changes

server/db/schema/clubs.schema.ts Show resolved Hide resolved

server/db/schema/notifications.schema.ts Outdated Show resolved Hide resolved

server/db/schema/clubs.schema.ts Show resolved Hide resolved

vercel bot had a problem deploying to Preview April 19, 2025 11:45 Failure

aryansri-19 reviewed Apr 20, 2025

View reviewed changes

app/[locale]/@modals/(.)student-activities/clubs/[display_name]/event/page.tsx Show resolved Hide resolved

heydoyouknowme0 reviewed Apr 20, 2025

View reviewed changes

server/db/schema/club-heads.schema.ts Outdated Show resolved Hide resolved

heydoyouknowme0 reviewed Apr 20, 2025

View reviewed changes

vercel bot had a problem deploying to Preview April 21, 2025 06:52 Failure

vercel bot had a problem deploying to Preview May 2, 2025 07:19 Failure

aryansri-19 force-pushed the staged branch from b6e1c44 to 767667b Compare June 9, 2025 07:26

aryansri-19 force-pushed the staged branch from d779e5f to 5d5f958 Compare June 24, 2025 08:20

vercel bot had a problem deploying to Preview June 28, 2025 15:20 Failure

vercel bot had a problem deploying to Preview June 28, 2025 17:26 Failure

vercel bot had a problem deploying to Preview June 28, 2025 17:57 Failure

KambojRajan and others added 18 commits June 29, 2025 12:41

fix club name

3dfdad5

redesign: page design change

c5b4c55

med

39f8e9b

fix: minor ui fix and scroll fix

00a1d1b

fix: fixed ui for single club page

9e12c56

feat:Changed the modal layout in club page

6941363

fix: fixed ui for single clubs page

2f96127

fix: typo and formatting

131a5e7

fix: proper filtering and more club members

c9890c1

fix: Reverted some changes

6400c8d

fix: Added club-heads and reverted some previous changes

94190e3

fix : some schema changes

5d79f09

fix: some schema changes

12484eb

fix: fixed image header

e396ed8

fix: Minor changes to modal

96adf20

fix:Fixing Translations

c596750

fix: Making changes to rebase

e06cfba

Revert "fix: Making changes to rebase"

ccc043b

This reverts commit d509924.

aryansri-19 force-pushed the feat/clubs branch from 0101611 to ccc043b Compare June 29, 2025 07:30

vercel bot had a problem deploying to Preview June 29, 2025 07:31 Failure

fix: build errors and schema changes

64462bf

vercel bot deployed to Preview June 30, 2025 05:54 View deployment

aryansri-19 requested changes Jul 5, 2025

View reviewed changes

fix: fixed the wrong redirect on clubs page

c822128

vercel bot deployed to Preview July 9, 2025 17:01 View deployment

fix: Fixed the modal on clubs page

4e02b56

vercel bot deployed to Preview July 9, 2025 22:07 View deployment

Feat/clubs #284

Are you sure you want to change the base?

Feat/clubs #284

Uh oh!

Conversation

Aryawart-kathpal commented Apr 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aryansri-19 commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aryawart-kathpal commented Apr 16, 2025

Uh oh!

aryansri-19 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aryansri-19 commented Apr 18, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aryawart-kathpal commented Apr 21, 2025

Uh oh!

heydoyouknowme0 commented Apr 30, 2025

Uh oh!

aryansri-19 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aryansri-19 commented Apr 14, 2025 •

edited

Loading