-
Notifications
You must be signed in to change notification settings - Fork 12
Feat/clubs #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staged
Are you sure you want to change the base?
Feat/clubs #284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
server/db/schema/notifications.schema.ts:26
- The commented-out clubId field suggests a missing foreign key relation in notifications; if not needed, consider removing it to avoid confusion.
// clubId: integer('club_id').references(() => clubs.id),
server/db/schema/clubs.schema.ts:43
- Consider removing or updating the commented-out code for facultyInchargeId3 if it is no longer intended for use to improve code clarity.
// facultyInchargeId3: integer('faculty_incharge_id3').references(() => faculty.id
server/db/schema/events.ts:16
- [nitpick] Consider using a more descriptive column name (e.g. 'start_date') instead of 'date' for the startDate field to improve clarity and consistency.
startDate: timestamp('date').notNull(),
app/[locale]/@modals/(.)student-activities/clubs/[dispaly_name]/event/page.tsx:1
- The folder parameter '[dispaly_name]' appears to be misspelled; consider renaming it to '[display_name]' for consistency with other parts of the codebase.
import Image from 'next/image';
74fbbae
to
ecd9ba2
Compare
app/[locale]/academics/page.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why modify this file
components/carousels/gallery.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't edit components unless you have a good reason to.
Why are the changes commented out? |
@aryansri-19 please review these schema changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modify the faculty schema too for the many relation to clubHeads
and rebase once. |
app/[locale]/@modals/(.)student-activities/clubs/[display_name]/event/page.tsx
Show resolved
Hide resolved
components/image-header.tsx
Outdated
@@ -42,9 +44,10 @@ export default function ImageHeader({ | |||
{title} | |||
</h1> | |||
)} | |||
{children} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of scope of the pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were not made by me but priyanshu sir, I just reverted to this state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What?, when?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{children} is required for the text(heading and logo) that is displayed on the top of banner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm ok, just make that a separate commit when you are cleaning the tree, also why not just have a prop as image url or something similar, I think this is the only way we need something like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my latest commit, I have made this change, review this too..
I have added the display_name and logoUrl as props and removed the {chilren} prop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Par yaar goal nahi mara
@aryansri-19 please review the schema changes |
base your pr on master or another pr if its a stacked pr |
This reverts commit d509924.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢
}) | ||
.notNull(), | ||
createdAt: t.timestamp().defaultNow().notNull(), | ||
updatedAt: t | ||
.timestamp() | ||
.$onUpdate(() => new Date()) | ||
.notNull(), | ||
clubId: integer('club_id').references(() => clubs.id), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t.integer()
callback method should be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be changed semantically. Although its modal is the one that will always open, yet it should at least render the correct page.
Updted ui for single clubs page