Feat/cells #296
Feat/cells #296
Conversation
| <div className="absolute left-1/2 top-1/2 -translate-x-1/2 -translate-y-1/2 text-center"> | ||
| <h1 | ||
| className="mx-2 my-auto text-xl md:text-2xl lg:text-3xl xl:text-4xl" | ||
| style={{ color: 'black' }} |
There was a problem hiding this comment.
use tailwind
text-neutral-900
| <TableRow> | ||
| <TableHead>Sr. No.</TableHead> | ||
| <TableHead>Responsibility</TableHead> | ||
| <TableHead>Name of Faculty</TableHead> | ||
| </TableRow> |
There was a problem hiding this comment.
For table headers, use translations
| <TableRow> | ||
| <TableHead>Sr. No.</TableHead> | ||
| <TableHead>Past activities</TableHead> | ||
| </TableRow> |
There was a problem hiding this comment.
Looks fine, just use tailwind wherever used style
| /> | ||
| <section className="w-full"> | ||
| <div> | ||
| <Table scrollAreaClassName="h-96"> |
There was a problem hiding this comment.
make table horizontally scrollable for smaller screens like mobile ( generally 648px )
| @@ -12,7 +12,22 @@ export interface Translations { | |||
| more: string; | |||
| }; | |||
| }; | |||
|
|
|||
| club: { | |||
There was a problem hiding this comment.
The key in translation should be Capitalized
There was a problem hiding this comment.
I have not made this change, may be someone else had made this change previously
|
@aryansri-19 please review the changes |
|
Been a while, let's see |
|
@aryansri-19 See the commit stack above, these are not only my changes, it includes changes made by 7 people. My base branch is not master in this pr, but staged. |
but the changes you made are not in all those 18 files, right? |
Can't do it right now, because I am using some changes here that I had made in feat/cells.. |
Initialized the ipr-cell page under the research tab.
Linked to issue #290