chore(build): shrink Makefile, Dockerfile strip block, pyproject, e2e fixtures - #690
Merged
Merged
Conversation
… fixtures (#681) - Makefile: drop test-e2e/-headed/-report wrappers (duplicate npm scripts); generate help from '##' comments; fix .PHONY. - Dockerfile: keep high-yield stdlib removals, drop per-.so codec surgery pinned to python3.13 paths. - pyproject: remove dead testpaths; 'C' already selects C4. - CI: ruff/pyright installed from the dev dependency group (single source of tool versions). - e2e: drop appUrl fixture (use baseURL); inline AboutPage page object. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 43 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 25, 2026
Merged
JAAdventurer
pushed a commit
to JAAdventurer/seedsync
that referenced
this pull request
Aug 25, 2026
CLAUDE.md is now a symlink to AGENTS.md. Content rewritten in a terse rules style, with stale items fixed: Font Awesome (removed in nitrobass24#688), Makefile e2e targets (removed in nitrobass24#690), CI publish matrix (dispatch tags by branch), mutating-service reference (CollectionService), test counts dropped. New rules: no AI attribution in commits/PRs, preserve mixed CRLF/LF line endings, master PRs limited to release or sync PRs sized for CodeRabbit, local test commands and known local-only failures.
nitrobass24
added a commit
that referenced
this pull request
Aug 25, 2026
CLAUDE.md is now a symlink to AGENTS.md. Content rewritten in a terse rules style, with stale items fixed: Font Awesome (removed in #688), Makefile e2e targets (removed in #690), CI publish matrix (dispatch tags by branch), mutating-service reference (CollectionService), test counts dropped. New rules: no AI attribution in commits/PRs, preserve mixed CRLF/LF line endings, master PRs limited to release or sync PRs sized for CodeRabbit, local test commands and known local-only failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #681. Part of #682.
Summary
test-e2e/test-e2e-headed/test-e2e-report(byte-for-byte duplicates of the npm scripts insrc/e2e-playwright);helpis now generated from##target comments so it can't drift;.PHONYfixed (test-e2e-dockeradded, dead targets removed).test,unittest,tkinter,idlelib,ensurepip,include,__pycache__); drop the ~35 lines of per-.socodec/encodings surgery pinned topython3.13/*paths.testpaths(never applied; would have excludedtests/integration); dropC4from ruffselectsinceCalready covers it (comment corrected).devdependency group (uv pip install --group dev) so tool versions have one source of truth.appUrlfixture (usebaseURL); inline theAboutPagepage object intoabout.spec.ts.Partial on item 4 of the issue:
apiGet/apiFetch/apiSetConfigare kept as Node-fetchhelpers. ~100 call sites depend on the WHATWGResponseshape (.ok,.status,.json()), and Playwright'srequestfixture returnsAPIResponse(.ok(),.status()) — swapping means touching every spec for ~20 lines of savings. Not worth it.Net: 35 insertions, 122 deletions.
Image size (compressed, from ghcr manifests)
developWithin the "few MB" budget the issue set for dropping the hand-maintained strip list.
Test plan
make helprenders all targetsruff checkclean;--select C4,C90still activetestpathsghcr.io/nitrobass24/seedsync:chore-build-tooling-shrinkmake build && make runlocally (Docker not running on this machine; CI's Build & Test job covers container start)🤖 Generated with Claude Code