ci: handle workflow_dispatch on tag refs; docs deploy note - #698
Merged
Merged
Conversation
…nly on master pushes A workflow_dispatch on a refs/tags/* ref produced no image tag from type=ref,event=branch, and since the dispatch metadata step runs last it emptied the manifest command's -t list. Add type=ref,event=tag.
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses two CodeRabbit findings from #694 (fixed here on
developsomasternever gets ahead; rides into #695).ci.yml: manual-dispatch metadata now also emitstype=ref,event=tag, so a dispatch onrefs/tags/*still yields an image tag for the manifest step (previously the last-run dispatch step overwrote release metadata with an empty tag list).website/README.md: deploy note now states the docs workflow publishes only whenwebsite/changes are pushed tomaster.Skipped from the same review:
threading.Lockannotation →_thread.LockType(valid class on the 3.13 runtime, pyright strict passes);latestCheckedspec subscription (outside diff, test-only, no behavioral effect).Test plan