Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/lsp: add pest-language-server #718

Closed
wants to merge 0 commits into from
Closed

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Nov 20, 2023

No description provided.

@traxys
Copy link
Member

traxys commented Nov 21, 2023

Could you rebase on master? There was an issue with master that has been fixed since then

@NickHu
Copy link
Contributor Author

NickHu commented Nov 21, 2023

Done

Comment on lines 424 to 428
{
name = "pest_ls";
description = "Enable pest-language-server, for pest";
package = pkgs.pest-ide-tools;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
name = "pest_ls";
description = "Enable pest-language-server, for pest";
package = pkgs.pest-ide-tools;
}
{
name = "pest-ls";
description = "Enable pest-language-server, for pest";
package = pkgs.pest-ide-tools;
serverName = "pest_ls";
}

We would adopt "nix-style" in this case.

@@ -421,6 +421,11 @@ with lib; let
'';
};
}
{
name = "pest_ls";
description = "Enable pest-language-server, for pest";
Copy link
Member

@GaetanLepage GaetanLepage Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "Enable pest-language-server, for pest";
description = "Enable pest_ls, for pest";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants