add revery #954
Open
add revery #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial version of a Revery derivation. It currently works only for macos. It relies on multiple patched repos that are not defined along with the top-level ocaml derivations, as they are specific to Revery. I happened to be using ocaml 5.0 when building this, so there are several patches to get libs work with >= 5.x. If this should be made compatible with 4.x, I'll test that and make them optional or tweak them where necessary. There is also an issue with static vs dynamic compilation I need to investigate, where not all libs are built statically. I noticed some of the dune files in Revery have two rules for static and dynamic, so perhaps both varieties should be made available.