Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEEDS MSRV >=1.77 | chore: replace memoffset with std API #2617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paolobarbolini
Copy link

What does this PR do

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nix is used by a lot of crates, bumping MSRV should be done carefully. Any reason why you want to do this?

@paolobarbolini
Copy link
Author

At the rate this crate bumped MSRV in the past this may be fine, but I'm also ok if you decide to stay on and order version for longer and this gets merged some time later.

@SteveLauC
Copy link
Member

but I'm also ok if you decide to stay on and order version for longer and this gets merged some time later.

I do not have an MSRV bumping strategy in my mind, but I think we should keep it close to the libc crate's MSRV, so I will stay, thanks:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants