Skip to content

Fix README.md. Missing ``` - #2077

Merged
nlohmann merged 1 commit into
nlohmann:developfrom
ArthurSonzogni:develop-2
May 1, 2020
Merged

nlohmann merged 1 commit into
nlohmann:developfrom
ArthurSonzogni:develop-2

Conversation

@ArthurSonzogni

Copy link
Copy Markdown
Contributor

This patch follows the one from: #2074.

An error has been introduced by accepting the suggestions. See:
ArthurSonzogni@4be4a03

One suggestion was about removing ~~~, but it was meant to be replaced
by ``` in reality. This caused the README.md to be slightly broken.

About pull request:
nlohmann#2074

An error has been introduced by accepting the suggestions:
4be4a03

One was about removing ~~~, but it was meant to be replaced by ``` in
reality. This caused the README.md to be slightly broken.
@ArthurSonzogni
ArthurSonzogni requested a review from nlohmann as a code owner May 1, 2020 12:03
@ArthurSonzogni

Copy link
Copy Markdown
Contributor Author

Hi again,

It looks like there was a small issue in the previous patch. I blindly accepted all the suggestions, but I didn't realize one was removing ~~~ without replacing it with ```

Could you please take a look?

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this May 1, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone May 1, 2020
@nlohmann
nlohmann merged commit 2251741 into nlohmann:develop May 1, 2020
@ArthurSonzogni

Copy link
Copy Markdown
Contributor Author

Thanks!

@nlohmann

nlohmann commented May 1, 2020

Copy link
Copy Markdown
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants