Skip to content

fixes unused variable 'ex' for #2304 - #2305

Merged
nlohmann merged 2 commits into
nlohmann:developfrom
AODQ:develop
Jul 25, 2020
Merged

nlohmann merged 2 commits into
nlohmann:developfrom
AODQ:develop

Conversation

@AODQ

@AODQ AODQ commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

Adds (void) to ex variables to prevent warnings when exceptions are disabled, as described in #2304 .

@AODQ
AODQ requested a review from nlohmann as a code owner July 23, 2020 17:26
@coveralls

coveralls commented Jul 23, 2020 •

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 15ec0fe on AODQ:develop into 43e07bb on nlohmann:develop.

Comment thread include/nlohmann/detail/input/json_sax.hpp Outdated
@nlohmann nlohmann linked an issue Jul 24, 2020 that may be closed by this pull request

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.8.1 milestone Jul 25, 2020
@nlohmann
nlohmann merged commit 808aca4 into nlohmann:develop Jul 25, 2020
@nlohmann

Copy link
Copy Markdown
Owner

Thanks!

@nlohmann

Copy link
Copy Markdown
Owner

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clang 10.0 / GCC 10.1 warnings on disabled exceptions

3 participants