Conversation
4 tasks
MBalszun
reviewed
Dec 31, 2020
nlohmann
marked this pull request as draft
January 1, 2021 16:38
This was
linked to
issues
Mar 23, 2021
This was referenced Mar 24, 2021
karzhenkov
reviewed
Mar 24, 2021
| add_custom_target(ci_test_noimplicitconversions | ||
| COMMAND CXX=${CLANG_TOOL} ${CMAKE_COMMAND} | ||
| -DCMAKE_BUILD_TYPE=Debug -GNinja | ||
| -DJSON_BuildTests=ON -DJSON_MultipleHeaders=ON -DJSON_ImplicitConversions=ON |
Contributor
There was a problem hiding this comment.
Suggested change
| -DJSON_BuildTests=ON -DJSON_MultipleHeaders=ON -DJSON_ImplicitConversions=ON | |
| -DJSON_BuildTests=ON -DJSON_MultipleHeaders=ON -DJSON_ImplicitConversions=OFF |
Owner
Author
|
@karzhenkov Thanks, good catch! Fixed in 9d57351. |
This was referenced Oct 13, 2021
Merged
nlohmann
added a commit
that referenced
this pull request
Sep 24, 2026
The target has configured ${PROJECT_SOURCE_DIR}/benchmarks since it was
added in #2561, but the benchmarks live in tests/benchmarks.
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR overworks the targets to execute in the CI and when a release is prepared. Right now, these steps are distributed over the configuration files of Travis, AppVeyor, and GitHub Actions, as well as the project's Makefile and some Python scripts. The goal is to have some CMake-based targets that are then executed by a (much simpler) CI. I would also like to get rid of the project's Makefile altogether.
Note: This PR may need to add some targets for MSVC as done in #2245. Closes #1798.