Skip to content

Fix spelling - #3125

Merged
nlohmann merged 1 commit into
nlohmann:developfrom
axic:codespell
Nov 9, 2021
Merged

nlohmann merged 1 commit into
nlohmann:developfrom
axic:codespell

Conversation

@axic

@axic axic commented Nov 6, 2021

Copy link
Copy Markdown
Contributor

I am trying to use the single_include version of this library in a project (here), and to simplify matters I thought to just include the file (or perhaps via subtree).

This means most of the linter tools run on the project would check this file. This is how I found the following complaints from codespell. I certainly can exclude this file from that tool, but thought it may be useful here too.

@axic
axic requested a review from nlohmann as a code owner November 6, 2021 22:45
Comment thread include/nlohmann/detail/input/binary_reader.hpp
@coveralls

coveralls commented Nov 7, 2021 •

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 959d69f on axic:codespell into 5c08a52 on nlohmann:develop.

@nlohmann

nlohmann commented Nov 7, 2021

Copy link
Copy Markdown
Owner

The CI failed: You need to edit the individual files in the include directory and then execute make amalgamate to create the single header.

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit the files in include and call make amalgamate to create the single header.

@axic

axic commented Nov 7, 2021

Copy link
Copy Markdown
Contributor Author

Please edit the files in include and call make amalgamate to create the single header.

I though I ran it, but apparently didn't. Fixed now.

@axic
axic requested a review from nlohmann November 7, 2021 17:40
Comment thread include/nlohmann/detail/output/binary_writer.hpp Outdated

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann

nlohmann commented Nov 7, 2021

Copy link
Copy Markdown
Owner

Thanks a lot! I will merge once the CI is done.

@nlohmann
nlohmann merged commit 8349180 into nlohmann:develop Nov 9, 2021
@axic
axic deleted the codespell branch November 9, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants