Add documentation for integration with CMake and hunter - #671
Merged
Merged
Conversation
nlohmann
requested changes
Jul 31, 2017
nlohmann
left a comment
Owner
There was a problem hiding this comment.
I don't want to have a too long explanation for all the different package managers. The description should be written so that people already familiar with the package managers know what to do.
| [...] | ||
| hunter_add_package(nlohmann_json) | ||
| find_package(nlohmann_json CONFIG REQUIRED) | ||
| target_link_libraries(... nlohmann_json) |
Owner
There was a problem hiding this comment.
This is quite verbose. Is it possible to describe this shorter as it is done for Meson, Conan, or Homebrew?
Contributor
Author
|
Ohh ok. |
Owner
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here you go, as requested. I added again the
LANGUAGES CXXand also added the documenation about using it with CMake and CMake with hunter.Hunter just released his latest version with supporting the version v2.1.1 of
nlohman_json👍