feat(converters)!: add OutputDestination and refactor Converter trait #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit output routing to converters-core with three modes: - Derived: derive output path from input (e.g., .adoc → .html) - Stdout: write to stdout (via -o -) - File: write to specific path (via -o path) Refactor Converter trait (renamed from Processable): - convert() is now a provided method with routing logic - Add convert_to_stdout() and convert_to_file() provided methods - Add write_to() as the core method converters must implement - Add derive_output_path() returning Result to properly propagate errors - Add after_write() hook for post-processing (e.g., CSS copying)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit output routing to converters-core with three modes:
Refactor Converter trait (renamed from Processable):