better tables #316
Open
better tables #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tables now properly handle cell-level formatting that was previously only supported at the column level. This brings parity with asciidoctor for common table patterns. Key changes: - Cell alignment overrides column defaults (^|, >|, .<|, .^|, .>|) - Cell duplication creates N identical cells (3*| Same) - Rowspan tracking prevents cell overlap in subsequent rows
Tables now render with proper CSS classes for frame, grid, stripes, width, and custom roles - matching asciidoctor output. Also consolidates attribute string extraction into ElementAttributes methods (get_string) removing duplicate helper functions from icon.rs and table.rs.
Cell positions were off by one column because the calculation used part boundaries directly instead of accounting for whitespace and cell specifiers. The fix calculates actual content offsets by tracking leading whitespace, specifier length, and post-specifier whitespace before computing positions.
The condition for skipping the first part after splitting was checking `!is_csv` when it should've been `separator == "|"`. PSV format has an empty first part (before the leading `|`), but DSV format doesn't - the first part is actual content. Also added unit tests for the split_escaped function and fixtures for both PSV and DSV escape handling.
The csv crate strips quotes and normalizes content, so we need to scan the raw text to find where fields actually start. Now "Hello\nWorld" correctly points to line 4:8 (inside the quotes) instead of some approximated offset that ignored quote characters entirely. Added proper RFC 4180 handling for escaped quotes too.
It seems counters are not so hot (https://asciidoc.zulipchat.com/#narrow/channel/335219-asciidoc-lang/topic/counters/near/568691273) so I've decided to just add a warning if we detect them but not actually do anything with them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.