feat: add helper middleware to easily define metrics config on a route#87
Open
lefuturiste wants to merge 2 commits intonlopes:mainfrom
Open
feat: add helper middleware to easily define metrics config on a route#87lefuturiste wants to merge 2 commits intonlopes:mainfrom
lefuturiste wants to merge 2 commits intonlopes:mainfrom
Conversation
lefuturiste
force-pushed
the
main
branch
2 times, most recently
from
52036c0 to
9ed4a29
Compare
Adding MetricsConfiguratorMiddleware to allow upstream code to provide a quick way to configure cardinality_keep_params with wrap even on route where wrap_fn is not as easy. example: wrap in route macro attribute.
Contributor
Author
|
Hello @nlopes I would love a review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding MetricsConfiguratorMiddleware to allow upstream code to
provide a quick way to configure cardinality_keep_params with wrap