feat: runtime-async-std #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a compile-time flag to support running on async-std's threadpool rather than a tokio one. This also switches out Reqwest for Surf, which has multiple http client backends, including a Hyper (tokio-compatible) one.
Fishrock123
force-pushed
the
runtime-async-std
branch
from
0a10e21 to
7731d01
Compare
Owner
|
Apologies @Fishrock123 but I merged a PR that improved things a bit with I also noticed that tests didn't successfully run, something to take a look at. Overall I like this change (the smaller the footprint the better). |
Contributor
Author
|
Ah shoot. It would have been easier to merge that after since surf is still playing catch-up a bit here. |
This was referenced Jan 19, 2021
|
is this work resumable @Fishrock123? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a compile-time flag to support running on async-std's threadpool rather than a tokio one.
This also switches out Reqwest for Surf, which has multiple http client backends, including a Hyper (tokio-compatible) one.
Note: these feature flags are mutually exclusive, and building does not work if none is specified (i.e.
--no-default-features).cc @nlopes