feat(idle-grace-overlay): use fade to black for smooth transition with noctalia:dpms-off#3037
Open
mattvilim wants to merge 1 commit into
Open
feat(idle-grace-overlay): use fade to black for smooth transition with noctalia:dpms-off#3037mattvilim wants to merge 1 commit into
mattvilim wants to merge 1 commit into
Conversation
…h noctalia:dpms-off
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I changed the idle grace color to black instead of shell surface because the transition is smooth in conjunction with idle dpms-off behavior (and won't change with wallpaper theme changes).
Motivation
Aesthetics are subjective, but I think this works as a better default. I considered adding a config field to let user choose but decided against it to avoid config bloat. Close if you disagree. 😃
Type of Change
Related Issue
N/A
Testing
Tested with:
Manual Coverage
Screenshots / Videos
N/A
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.Additional Notes