syntax: use std::println#3051
Merged
Merged
Conversation
Contributor
Author
|
Rebased and added this to the "chore: apply clang-tidy autofixes" commit: diff --git a/src/compositors/compositor_platform.cpp b/src/compositors/compositor_platform.cpp
index 611e73b20..607a05289 100644
--- a/src/compositors/compositor_platform.cpp
+++ b/src/compositors/compositor_platform.cpp
@@ -384,8 +384,8 @@ namespace {
return workspace.id;
}
}
- const bool numeric = !rawKey.empty()
- && std::all_of(rawKey.begin(), rawKey.end(), [](unsigned char ch) { return std::isdigit(ch) != 0; });
+ const bool numeric =
+ !rawKey.empty() && std::ranges::all_of(rawKey, [](unsigned char ch) { return std::isdigit(ch) != 0; });
if (numeric) {
const auto value = std::stoul(rawKey);
for (const auto& workspace : workspaces) {
diff --git a/src/compositors/kde/kwin_active_window.cpp b/src/compositors/kde/kwin_active_window.cpp
index dbbf1b809..28f3c87cd 100644
--- a/src/compositors/kde/kwin_active_window.cpp
+++ b/src/compositors/kde/kwin_active_window.cpp
@@ -453,7 +453,7 @@ for (const window of workspace.windowList()) {{
const std::string label = std::format("noctalia-activate-{}", ++m_transientScriptSerial);
if (!runTransientScript(script, label)) {
- kLog.warn("failed to activate kde window class=\"{}\" title=\"{}\"", appId, title);
+ kLog.warn(R"(failed to activate kde window class="{}" title="{}")", appId, title);
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.