Skip to content

syntax: use std::println#3051

Merged
ItsLemmy merged 2 commits into
noctalia-dev:mainfrom
Ape:pr/syntax-std-print
Jun 19, 2026
Merged

syntax: use std::println#3051
ItsLemmy merged 2 commits into
noctalia-dev:mainfrom
Ape:pr/syntax-std-print

Conversation

@Ape

@Ape Ape commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Ape Ape force-pushed the pr/syntax-std-print branch from 0ec0ff7 to bb20ee7 Compare June 19, 2026 10:35
@Ape

Ape commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Rebased and added this to the "chore: apply clang-tidy autofixes" commit:

diff --git a/src/compositors/compositor_platform.cpp b/src/compositors/compositor_platform.cpp
index 611e73b20..607a05289 100644
--- a/src/compositors/compositor_platform.cpp
+++ b/src/compositors/compositor_platform.cpp
@@ -384,8 +384,8 @@ namespace {
         return workspace.id;
       }
     }
-    const bool numeric = !rawKey.empty()
-        && std::all_of(rawKey.begin(), rawKey.end(), [](unsigned char ch) { return std::isdigit(ch) != 0; });
+    const bool numeric =
+        !rawKey.empty() && std::ranges::all_of(rawKey, [](unsigned char ch) { return std::isdigit(ch) != 0; });
     if (numeric) {
       const auto value = std::stoul(rawKey);
       for (const auto& workspace : workspaces) {
diff --git a/src/compositors/kde/kwin_active_window.cpp b/src/compositors/kde/kwin_active_window.cpp
index dbbf1b809..28f3c87cd 100644
--- a/src/compositors/kde/kwin_active_window.cpp
+++ b/src/compositors/kde/kwin_active_window.cpp
@@ -453,7 +453,7 @@ for (const window of workspace.windowList()) {{
 
     const std::string label = std::format("noctalia-activate-{}", ++m_transientScriptSerial);
     if (!runTransientScript(script, label)) {
-      kLog.warn("failed to activate kde window class=\"{}\" title=\"{}\"", appId, title);
+      kLog.warn(R"(failed to activate kde window class="{}" title="{}")", appId, title);
     }
   }

@ItsLemmy ItsLemmy merged commit 5f276ee into noctalia-dev:main Jun 19, 2026
2 checks passed
@Ape Ape deleted the pr/syntax-std-print branch June 19, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants