fix(notification): support arbitrary notification actions and wrap them dynamically#3052
Open
the-daonm wants to merge 4 commits into
Open
fix(notification): support arbitrary notification actions and wrap them dynamically#3052the-daonm wants to merge 4 commits into
the-daonm wants to merge 4 commits into
Conversation
…s in DesktopButtonWidget
Contributor
Author
|
I also fix the bug causing the lint failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where
noctaliasilently dropped notification actions beyond the first two in both the toast notification and the notification center/history tab. The hardcoded limits of2action buttons have been removed. Additionally, action buttons are now dynamically wrapped onto multiple horizontal rows when their cumulative widths exceed the card's available width limit. Within each wrapped row, buttons are configured withflexGrow = 1.0fto stretch and share the horizontal space evenly, matching modern UI standards.Motivation
This solves the problem where clients (such as
notify-send) supplying more than two actions are unable to display them to the user, rendering critical notification controls unreachable.Type of Change
Related Issue
Closes #2934
Testing
just build,just test,just runworkManual Coverage
Screenshots / Videos
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.Additional Notes