feat(osd): add privacy indicator OSD when mic, camera, screenshare enable/disable#3061
Merged
Merged
Conversation
Contributor
Author
Lint failure is in main and unrelated to this PR. |
7e3777b to
733fb19
Compare
733fb19 to
9d4a83d
Compare
Collaborator
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#3040 added a privacy indicator widget to show mic, camera, screenshare state. This PR adds OSD notifications when privacy indicator enables/disables.
This PR adds 6 i18n OSD keys:
osd.privacy.mic-onosd.privacy.mic-offosd.privacy.camera-onosd.privacy.camera-offosd.privacy.screen-onosd.privacy.screen-offIt adds 2 i18n UI keys:
settings.schema.shell.osd-kinds-privacy.labelsettings.schema.shell.osd-kinds-privacy.descriptionThe new OSD config to toggle this feature is added to GUI settings. If the PR is accepted, I will create a docs PR to update the OSD config documentation.
Motivation
Gives more visible notice of privacy state changes
Type of Change
Related Issue
#3040
Testing
I tested with mic and screen share enable/disable. I don't have a camera and did not test it. When multiple privacy events happen in rapid succession (e.g. leave call that had screen share and mic enabled), the existing OSD popup logic handles animating the first and showing the others overwritten in succession.
Manual Coverage
Screenshots / Videos
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.Additional Notes