Initial implementation of artifact bundles. #33
Conversation
| # {slice}_{dist_bundle_name}_{component}_{variant}.tar.xz | ||
| # | ||
| # - {slice}: For single sub-project slices, this is just the sub-project name | ||
| # as known to TheRock (e.g. amd-llvm, hipify, hipBLASLt, etc). For multi | ||
| # project slices, it is something descriptive and non-overlapping (e.g. | ||
| # "base"). |
There was a problem hiding this comment.
Out of curiosity, are there naming restrictions for these, like only having [a-zA-Z0-9\-] characters?
| # ROCm Dist Artifacts | ||
| # A primary output of the build system is a set of archive slices of key | ||
| # components. In typical CI flows, these are archived into tarballs and made | ||
| # available to successor jobs as artifacts. Successor jobs can use them for |
There was a problem hiding this comment.
What orders of magnitude are we talking about here?
- 100s-1000s of artifacts?
- each artifact 1MB-10GB in size? Or are some significantly larger?
| # A primary output of the build system is a set of archive slices of key | ||
| # components. In typical CI flows, these are archived into tarballs and made | ||
| # available to successor jobs as artifacts. Successor jobs can use them for |
There was a problem hiding this comment.
Where do you expect artifacts to be stored? GitHub-native locations like GitHub workflow artifacts for CI pipelines and/or GitHub packages for some components?
I presume some artifacts will be uploaded to package repositories and historical archives. Could these outputs eventually push to existing locations, replacing the existing tooling for that?
| # - "comm-libs-rccl": The RCCL sub-project. | ||
| # Dependencies: base, core-hip, compiler-hipify | ||
| # Target specificity: Yes |
There was a problem hiding this comment.
Is there a (public) chart showing this dependency graph? Should TheRock include one? Are there any dependency links that we want to rework as part of this (e.g. decoupling components)?
There was a problem hiding this comment.
Stella doesn't draw :)
But there probably should be.
No description provided.