Skip to content

Commit

Permalink
[CI] remove unused multi-dispatch tests (#1110)
Browse files Browse the repository at this point in the history
The multi-dispatch tests were not being run because of


```
   if config.xdna_datetime and config.xdna_datetime < 20240801:
```

Moreover the overall class structure no longer makes sense if these
tests are present. So rather than doing the heavy lift involved in
getting these tests playing nicely again, I propose removing them. Also,
I think by the time we get to multi dispatch work the stack will have
changed to the point that these tests are no longer relevant.
  • Loading branch information
newling authored Feb 17, 2025
1 parent 5755830 commit 44cda58
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 184 deletions.
34 changes: 0 additions & 34 deletions build_tools/ci/cpu_comparison/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,36 +236,6 @@ def _execute(self, config):
return run_conv_test(config, self.aie_compilation_flags, filename, n_repeats=1)


class MultipleDispatches(BaseTest):
def __init__(
self,
name,
test_params=None,
):
super().__init__(
name=name,
test_params=test_params,
)
self.labels += ["Matmul", "MultipleDispatches"]

def _execute(self, config):
test_files_dir = config.file_dir / "test_files"
self.filename = test_files_dir / f"{self.name}.mlir"
# TODO(newling) did Maks ever document why this is here, if so add an
# explainer.
if config.xdna_datetime and config.xdna_datetime < 20240801:
aie_vs_llvm_cpu(
config,
self.aie_compilation_flags,
self.filename,
function_name="three_$mm$",
)
return True
else:
# Return False to indicate that the test did not run.
return False


class BaseMatmul(BaseTest):
def __init__(
self,
Expand Down Expand Up @@ -2493,10 +2463,6 @@ def __init__(self):
)
)

# MultipleDispatches tests:
for name in ["two_matmul_switching", "matmul_f32_8_8_4", "matmul_f32_8_4_8"]:
self.register(MultipleDispatches(name))

# Convolution NHCWQ test:
self.register(ConvolutionNHWCQ())

Expand Down
35 changes: 0 additions & 35 deletions build_tools/ci/cpu_comparison/test_files/matmul_f32_8_4_8.mlir

This file was deleted.

40 changes: 0 additions & 40 deletions build_tools/ci/cpu_comparison/test_files/matmul_f32_8_8_4.mlir

This file was deleted.

32 changes: 0 additions & 32 deletions build_tools/ci/cpu_comparison/test_files/three_matmuls.mlir

This file was deleted.

43 changes: 0 additions & 43 deletions build_tools/ci/cpu_comparison/test_files/two_matmul_switching.mlir

This file was deleted.

0 comments on commit 44cda58

Please sign in to comment.