Review comment v5.0

nod-ai · Jan 29, 2025 · 531ee50 · 531ee50
1 parent 509fb6d
commit 531ee50
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/compiler/plugins/target/AMD-AIE/iree-amd-aie/IR/AMDAIELogicalObjFifoOpInterface.cpp b/compiler/plugins/target/AMD-AIE/iree-amd-aie/IR/AMDAIELogicalObjFifoOpInterface.cpp
@@ -17,10 +17,10 @@ SmallVector<mlir::CopyOpInterface> getCopyLikeConsumers(
     LogicalObjFifoOpInterface op) {
   SmallVector<mlir::CopyOpInterface> copyLikOps;
   for (Operation *userOp : op->getUsers()) {
-    if (auto copyOp = dyn_cast<CopyOpInterface>(userOp)) {
-      if (dyn_cast_if_present<LogicalObjFifoOpInterface>(
-              copyOp.getSource().getDefiningOp()) == op)
-        copyLikOps.push_back(copyOp);
+    if (auto copyOp = dyn_cast<CopyOpInterface>(userOp);
+        copyOp && dyn_cast_if_present<LogicalObjFifoOpInterface>(
+            copyOp.getSource().getDefiningOp()) == op) {
+      copyLikOps.push_back(copyOp);
     }
   }
   return copyLikOps;
@@ -30,10 +30,10 @@ SmallVector<mlir::CopyOpInterface> getCopyLikeProducers(
     LogicalObjFifoOpInterface op) {
   SmallVector<mlir::CopyOpInterface> copyLikOps;
   for (Operation *userOp : op->getUsers()) {
-    if (auto copyOp = dyn_cast<CopyOpInterface>(userOp)) {
-      if (dyn_cast_if_present<LogicalObjFifoOpInterface>(
-              copyOp.getTarget().getDefiningOp()) == op)
-        copyLikOps.push_back(copyOp);
+    if (auto copyOp = dyn_cast<CopyOpInterface>(userOp);
+        copyOp && dyn_cast_if_present<LogicalObjFifoOpInterface>(
+            copyOp.getTarget().getDefiningOp()) == op) {
+      copyLikOps.push_back(copyOp);
     }
   }
   return copyLikOps;