Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KernelDispatch] Add matmul RHS outer permutation #1016

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jtuyls
Copy link
Collaborator

@jtuyls jtuyls commented Jan 9, 2025

Permutes the level 0 RHS pack operations to always get RHS/B on L2 into the packed layout [N K ? ?] instead of [K N ? ?]. This is needed for splitting on the outer dimension when caching more of K in L2 (K > 1).

Copy link
Contributor

@yzhang93 yzhang93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jtuyls jtuyls merged commit 53b96d5 into nod-ai:main Jan 9, 2025
6 checks passed
@jtuyls jtuyls deleted the rhs-permutation branch January 14, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants