[IR] Pretty-printer for LogicalObjectFifoFromMemrefOp #1017
Conversation
newling
requested review from
MaheshRavishankar,
nirvedhmeshram,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
There was a problem hiding this comment.
Nice addition!
I have a naming related request if it's okay - since we have tile assignment related pass/functionality, perhaps we make a difference (naming-wise) between a LOF that :-
- has not been assigned any tile.
- has been assigned with unknown tiles/tiles on different row and col.
| memref<8xi32> -> !amdaie.logicalobjectfifo<memref<8xi32>> | ||
|
|
||
| // logicalobjectfifo with a tile with a known column, unkown row: | ||
| // CHECK: %lof_2_r_6 = |
There was a problem hiding this comment.
I'd expect this to be %lof_2_r_0 or %lof_2_r_1 or %lof_2_r_2 instead %lof_2_r_6 - not sure where the last _6 is coming from.
There was a problem hiding this comment.
Let me explain and then improve!
Explanation: there is a %tile_0 and a %tile_1 before %lof_2_r_2, that's why it's starting at 2 not 0.
Improvement TODO: (1) tiles can have better suffixing (2) separate into 2+ lit tests.
compiler/plugins/target/AMD-AIE/iree-amd-aie/IR/test/roundtrip.mlir
Outdated
Show resolved
Hide resolved
| memref<8xi32> -> !amdaie.logicalobjectfifo<memref<8xi32>> | ||
|
|
||
| // logicalobjectfifo with a single unknown tile: | ||
| // CHECK: %lof_2 = |
There was a problem hiding this comment.
Similarly I'd expect this as %lof_0 or %lof_1 ?
Ok. I guess that would mean something like |
newling
force-pushed
the
from_memref_ir_sugar
branch
from
844c980 to
af5474c
Compare
newling
force-pushed
the
from_memref_ir_sugar
branch
from
af5474c to
672e5b3
Compare
Will now be `%tile_c_3` and `%tile_2_r` if one or other of the column and row are integers. As opposed to just `%tile` and `%tile_1`. This aligns tile printing with the [printing of logicalobjectfifos](#1017).
Makes IR easier to mentally parse -- it should be easier to figure out which columns/rows a
LogicalObjectFifoFromMemrefOpis on.The lit tests have more examples