Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use pre-commit (copy IREE) for linting #1020

Merged
merged 16 commits into from
Jan 13, 2025

Conversation

newling
Copy link
Contributor

@newling newling commented Jan 10, 2025

This PR aligns iree-amd-aie's linting with IREE's. It copies files https://github.com/iree-org/iree/blob/main/.pre-commit-config.yaml and https://github.com/iree-org/iree/blob/main/.github/workflows/lint.yml , with the only change being a removal of basel and yml linting, as we don't have basel or yml in iree-amd-aie (and the basel linter was failing).

This PR also includes the changes needed to pass the linter. Running pre-commit run --all-files basically did everything needed, with 2 places where a clang-format off/on pair was needed to avoid header rearrangement.

Note to developers: if your PR fails linting after this lands, it's very easy to fix locally: pip install pre-commit and then run pre-commit on all or a subset of the project files.

{0378F65F-6FDD-4765-9E8E-378380638A74}

@newling newling changed the title [CI] Copy iree's lint .yml file [CI] Use pre-commit (copy IREE) for linting Jan 10, 2025
Copy link
Collaborator

@jtuyls jtuyls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

newling and others added 2 commits January 10, 2025 15:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Abhishek-Varma Abhishek-Varma enabled auto-merge (squash) January 13, 2025 06:57
@Abhishek-Varma Abhishek-Varma merged commit af8016e into nod-ai:main Jan 13, 2025
4 of 5 checks passed
Abhishek-Varma added a commit that referenced this pull request Jan 13, 2025
-- This commit addresses Linting errors in main as a follow-up
   of #1020.

Signed-off-by: Abhishek Varma <[email protected]>
Abhishek-Varma added a commit that referenced this pull request Jan 13, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
-- This commit addresses Linting errors in main as a follow-up of
[#1020.](#1020)

Signed-off-by: Abhishek Varma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants