-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Use pre-commit (copy IREE) for linting #1020
Merged
Merged
+1,038
−953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtuyls
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Abhishek-Varma
added a commit
that referenced
this pull request
Jan 13, 2025
-- This commit addresses Linting errors in main as a follow-up of #1020. Signed-off-by: Abhishek Varma <[email protected]>
Abhishek-Varma
added a commit
that referenced
this pull request
Jan 13, 2025
-- This commit addresses Linting errors in main as a follow-up of [#1020.](#1020) Signed-off-by: Abhishek Varma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns iree-amd-aie's linting with IREE's. It copies files https://github.com/iree-org/iree/blob/main/.pre-commit-config.yaml and https://github.com/iree-org/iree/blob/main/.github/workflows/lint.yml , with the only change being a removal of basel and yml linting, as we don't have basel or yml in iree-amd-aie (and the basel linter was failing).
This PR also includes the changes needed to pass the linter. Running
pre-commit run --all-files
basically did everything needed, with 2 places where aclang-format off/on
pair was needed to avoid header rearrangement.Note to developers: if your PR fails linting after this lands, it's very easy to fix locally:
pip install pre-commit
and then run pre-commit on all or a subset of the project files.