Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELF] Add PM size to debug log #1065

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

jtuyls
Copy link
Collaborator

@jtuyls jtuyls commented Jan 29, 2025

No description provided.

@jtuyls jtuyls force-pushed the add-debug-pm-size branch from 8f2969a to 9463c9f Compare January 29, 2025 13:37
@jtuyls jtuyls changed the title [ELF] Add PM size to debug log in case of failure [ELF] Add PM size to debug log Jan 29, 2025
@jtuyls jtuyls force-pushed the add-debug-pm-size branch from 2040f8a to 2714a59 Compare January 29, 2025 14:20
Copy link
Contributor

@Abhishek-Varma Abhishek-Varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice!

Just one nit (not blocking on it) - if this PM reading/writing to file is kept it its own standalone utility and invoked right before addElfToTile.

@jtuyls jtuyls force-pushed the add-debug-pm-size branch from 2714a59 to 2e59073 Compare January 29, 2025 15:08
@jtuyls jtuyls merged commit 11b51d7 into nod-ai:main Jan 29, 2025
7 checks passed
@jtuyls jtuyls deleted the add-debug-pm-size branch January 29, 2025 16:16
@newling
Copy link
Contributor

newling commented Jan 29, 2025

LGTM. If you think the python equivalent is redundant, i.e.

def print_program_memory_size(test_dir):
we should remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants