Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add larger shape e2e bfp16 Ukernel test #1068

Open
wants to merge 1 commit into
base: avarma_fix_split_lof_for_new_pipeline
Choose a base branch
from

Conversation

Abhishek-Varma
Copy link
Contributor

-- This commit adds larger shape e2e bfp16 Ukernel test to CI for
both pack-peel as well as pack-peel-4-level-tiling targeting
4x8 array on Strix.
-- It wasn't working earlier (3 months ago) but now it does - hence
enabling.
-- To be merged after #1060

Signed-off-by: Abhishek Varma [email protected]

-- This commit adds larger shape e2e bfp16 Ukernel test to CI for
   both `pack-peel` as well as `pack-peel-4-level-tiling` targeting
   4x8 array on Strix.
-- It wasn't working earlier (3 months ago) but now it does - hence
   enabling.

Signed-off-by: Abhishek Varma <[email protected]>
@Abhishek-Varma Abhishek-Varma requested a review from jtuyls January 30, 2025 09:44
@yzhang93
Copy link
Contributor

You are not merging to the main branch? Also for this commit #1067

@Abhishek-Varma
Copy link
Contributor Author

You are not merging to the main branch? Also for this commit #1067

If you delete a head branch after its pull request has been merged, GitHub checks for any open pull requests in the same repository that specify the deleted branch as their base branch. GitHub automatically updates any such pull requests, changing their base branch to the merged pull request's base branch.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches#working-with-branches

@yzhang93
Copy link
Contributor

yzhang93 commented Jan 30, 2025

You are not merging to the main branch? Also for this commit #1067

If you delete a head branch after its pull request has been merged, GitHub checks for any open pull requests in the same repository that specify the deleted branch as their base branch. GitHub automatically updates any such pull requests, changing their base branch to the merged pull request's base branch.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches#working-with-branches

Are you sure this is what you want? #1067 is not in main branch. You have to use the main as the base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants