Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Modify matmul4d to use total size as input args #1112

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

yzhang93
Copy link
Contributor

Before this PR, input args M/N/K are the outer dims for matmul4d ops. For easier comparison with standard matmul, this PR keeps the use of M/N/K as total matmul input sizes, while adding inner dim sizes as another parameter.

Copy link
Collaborator

@jtuyls jtuyls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yzhang93 yzhang93 enabled auto-merge (squash) February 17, 2025 17:53
@yzhang93 yzhang93 merged commit d2ccc89 into nod-ai:main Feb 17, 2025
7 checks passed
@yzhang93 yzhang93 deleted the matmul4d_ci branch February 24, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants