Function to estimate stack size #1116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newling
requested review from
makslevental,
nirvedhmeshram,
MaheshRavishankar,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
newling
commented
Feb 19, 2025
jtuyls
approved these changes
Feb 19, 2025
|
|
||
| // Derived from lines containing substrings like 'paddb [sp], #224;' | ||
| // There is one vector of ints per function. | ||
| SmallVector<SmallVector<int>> bumps; |
There was a problem hiding this comment.
Nit, but you could use uint32_t as bumps would always be positive right? Same for a couple of other int variables in this function.
| llvm::errs() << "Failed to get stack size from assembly file\n"; | ||
| return failure(); | ||
| } | ||
| auto upperBounds = std::move(maybeUpperBounds.value()); |
There was a problem hiding this comment.
Suggested change
| auto upperBounds = std::move(maybeUpperBounds.value()); | |
| llvm::DenseMap<std::pair<int, int>, int> upperBounds = std::move(maybeUpperBounds.value()); |
| << ") is not found in the assembly file. "; | ||
| return failure(); | ||
| } | ||
| auto stackSize = coreOp.getStackSize(); |
There was a problem hiding this comment.
Suggested change
| auto stackSize = coreOp.getStackSize(); | |
| int32_t stackSize = coreOp.getStackSize(); |
| mlir::FailureOr<llvm::DenseMap<std::pair<int, int>, int>> ubs = | ||
| detail::getUpperBoundStackSizes(asmStr); | ||
| EXPECT_TRUE(succeeded(ubs)); | ||
| // auto upperBounds = maybeUpperBounds.value(); |
There was a problem hiding this comment.
Suggested change
| // auto upperBounds = maybeUpperBounds.value(); |
| mlir::FailureOr<llvm::DenseMap<std::pair<int, int>, int>> ubs = | ||
| detail::getUpperBoundStackSizes(asmStr); | ||
| EXPECT_TRUE(succeeded(ubs)); | ||
| // auto upperBounds = maybeUpperBounds.value(); |
There was a problem hiding this comment.
Suggested change
| // auto upperBounds = maybeUpperBounds.value(); |
| mlir::FailureOr<llvm::DenseMap<std::pair<int, int>, int>> maybeUpperBounds = | ||
| detail::getUpperBoundStackSizes(asmStr); | ||
| EXPECT_TRUE(succeeded(maybeUpperBounds)); | ||
| auto upperBounds = maybeUpperBounds.value(); |
There was a problem hiding this comment.
Suggested change
| auto upperBounds = maybeUpperBounds.value(); | |
| llvm::DenseMap<std::pair<int, int>, int> upperBounds = maybeUpperBounds.value(); |
|
Closing in favor of #1121 |
newling
added a commit
that referenced
this pull request
Feb 21, 2025
This will replace #1116 -- instead of string matching the assembly file, it uses llvm's `llvm-readelf` after adding `--stack-size-section` to the llc call. Please read the paper trail of PRs I've left here for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simpler version of #1104
In this PR, the stack size is not set based on the assembly analysis, this PR just adds a check that the assigned stack is sufficient.
I have checked this locally by changing the stack size here and it works fine.
This should help avoid the bad situations like Xilinx/llvm-aie#342
Next steps (I'd like to do these in a separate PR):