Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump IREE requirement pins to 3.3.0rc20250215 #973

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Bump IREE requirement pins to 3.3.0rc20250215 #973

merged 2 commits into from
Feb 24, 2025

Conversation

shark-pr-automator[bot]
Copy link
Contributor

Diff: iree-org/iree@iree-3.3.0rc20250213...iree-3.3.0rc20250215

IREE bump duty engineer this week: @renxida

Auto-generated by GitHub Actions using .github/workflows/update_iree_requirement_pins.yml.

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@renxida
Copy link
Contributor

renxida commented Feb 17, 2025

FAILED sharktank/tests/models/vae/vae_test.py::VaeFluxDecoderTest::testCompareBF16EagerVsHuggingface - RuntimeError: Given groups=1, weight of size [512, 16, 3, 3], expected input[1, 1, 4096, 64] to have 16 channels, but got 1 channels instead
FAILED sharktank/tests/models/vae/vae_test.py::VaeFluxDecoderTest::testCompareF32EagerVsHuggingface - RuntimeError: Given groups=1, weight of size [512, 16, 3, 3], expected input[1, 1, 4096, 64] to have 16 channels, but got 1 channels instead
FAILED sharktank/tests/models/vae/vae_test.py::VaeFluxDecoderTest::testVaeIreeVsHuggingFace - RuntimeError: Given groups=1, weight of size [512, 16, 3, 3], expected input[1, 1, 4096, 64] to have 16 channels, but got 1 channels instead

Did we change the shape handling for something here?

@marbre
Copy link
Collaborator

marbre commented Feb 18, 2025

FAILED sharktank/tests/models/vae/vae_test.py::VaeFluxDecoderTest::testCompareBF16EagerVsHuggingface - RuntimeError: Given groups=1, weight of size [512, 16, 3, 3], expected input[1, 1, 4096, 64] to have 16 channels, but got 1 channels instead
FAILED sharktank/tests/models/vae/vae_test.py::VaeFluxDecoderTest::testCompareF32EagerVsHuggingface - RuntimeError: Given groups=1, weight of size [512, 16, 3, 3], expected input[1, 1, 4096, 64] to have 16 channels, but got 1 channels instead
FAILED sharktank/tests/models/vae/vae_test.py::VaeFluxDecoderTest::testVaeIreeVsHuggingFace - RuntimeError: Given groups=1, weight of size [512, 16, 3, 3], expected input[1, 1, 4096, 64] to have 16 channels, but got 1 channels instead

Did we change the shape handling for something here?

Do you follow up here or have investigated further @renxida?

@marbre
Copy link
Collaborator

marbre commented Feb 19, 2025

Seems the test failure is unrelated to the IREE version bump, I filled #982 for this.

@marbre
Copy link
Collaborator

marbre commented Feb 24, 2025

The issue was fixed in the shark-ai repo and were not related to the IREE version. Thus, we could merge this as is or directly try to bump to a newer version. @ScottTodd wdyt?

@marbre marbre requested a review from ScottTodd February 24, 2025 16:15
@ScottTodd
Copy link
Member

Incremental update is fine.

@ScottTodd
Copy link
Member

(We may still want to change the action to set the PR title to reflect the specific commit though, since this no longer has the "latest versions")

@marbre marbre changed the title Bump IREE requirement pins to their latest versions. Bump IREE requirement pins to 3.3.0rc20250215 Feb 24, 2025
@marbre marbre merged commit b5bc82a into main Feb 24, 2025
40 checks passed
@marbre marbre deleted the integrates/iree branch February 24, 2025 17:21
@renxida
Copy link
Contributor

renxida commented Feb 24, 2025

#996 implements the version-in-title change

renxida added a commit that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants