Explicitly check for None when using prefill attn_mask
#983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsuderman
approved these changes
Feb 19, 2025
IanNod
pushed a commit
that referenced
this pull request
Feb 22, 2025
When you attempt to implicitly null-check the attention_mask, you hit a torch error: ```bash RuntimeError: Cannot call numel() on tensor with symbolic sizes/strides ``` Simply adding an explicit check for null fixes it, and the `--use-attention-mask` export path for prefill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you attempt to implicitly null-check the attention_mask, you hit a torch error:
RuntimeError: Cannot call numel() on tensor with symbolic sizes/stridesSimply adding an explicit check for null fixes it, and the
--use-attention-maskexport path for prefill