[shortfin llm] Simplify interface between llm specific code and fastapi webapp #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renxida
changed the title
renxida
requested review from
stellaraccident and
stbaione
and removed request for
stellaraccident
IanNod
pushed a commit
that referenced
this pull request
Feb 22, 2025
…pi webapp (#985) Currently it's a little hard to trace through the server initialization code because a lot of global variables are involved. This PR eliminates them and uses a singe location to put a context manager for init-deinit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's a little hard to trace through the server initialization code because a lot of global variables are involved. This PR eliminates them and uses a singe location to put a context manager for init-deinit.