-
-
Notifications
You must be signed in to change notification settings - Fork 46
fix: NodeJS build for M1 iOS simulator #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this pr is copy from #23 and fix merge conflicts |
To be honest, I don't know much about this project yet. Are there any areas that need to be changed? |
Someone is going to merge this? We are having problems with this. |
Checking and testing this PR takes time, and my time is not for free, unfortunately. If it's blocking you, it is not hard to fork the repo and point your package.json dependency to My main concern is that this PR is adding a binary, and I wouldn't trust those from strangers, so first we would need a PR on nodejs-mobile/nodejs-mobile to support building the M1 Simulator binary, and then I can make a new version of that package and then use a locally built binary in the style of this n-m-r-n PR, and of course test on my M1 Mac that all this works. Again, unfortunately this is a multi-hour effort and I'm not going to do it on my customer's budgets or my scarce free time. |
No description provided.